ENH: Add itk::RelabelComponentImageFilter signedness check
#4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Infrastructure
|
Chose to keep it separate from It does not test anything other than those warnings reported in #4865 in reality. |
|
Linux and macOS CI builds raised the warnings since the history of this branch did not include the fix in #4865: However, as mentioned in #4865 (comment), Windows did not raise any warnings: Rebasing on |
jhlegarreta
force-pushed
the
AddRelabelComponentsImageFilterSignednessTest
branch
from
24e8e63
to
c58b9c0
Compare
N-Dekker
reviewed
Oct 6, 2024
Modules/Segmentation/ConnectedComponents/test/itkRelabelComponentImageFilterSignednessTest.cxx
Outdated
Show resolved
Hide resolved
jhlegarreta
force-pushed
the
AddRelabelComponentsImageFilterSignednessTest
branch
from
c58b9c0
to
a9fe742
Compare
N-Dekker
reviewed
Oct 7, 2024
Modules/Segmentation/ConnectedComponents/test/itkRelabelComponentImageFilterSignednessTest.cxx
Outdated
Show resolved
Hide resolved
N-Dekker
approved these changes
Oct 7, 2024
Add a template instantiation to check that the `itk::RelabelComponentImageFilter` class does not trigger compiler warnings with signed pixel types. Ensures regressions are not introduced after the fix in commit 108a2cf.
jhlegarreta
force-pushed
the
AddRelabelComponentsImageFilterSignednessTest
branch
from
a9fe742
to
4ba0ab0
Compare
github-actions
bot
removed
the
type:Infrastructure
jhlegarreta
changed the title
itk::RelabelComponenetsImageFilter signedness testitk::RelabelComponentImageFilter signedness test
jhlegarreta
changed the title
itk::RelabelComponentImageFilter signedness testitk::RelabelComponentImageFilter signedness check
See 4ba0ab0. |
dzenanz
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a template instantiation to check that the
itk::RelabelComponentImageFilterclass does not trigger compiler warnings with signed pixel types.Ensures regressions are not introduced after the fix in commit 108a2cf.
PR Checklist