Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Configure PyPi API Tokens For ITK Remote Modules: Part 1 #1921

Closed
18 tasks done
hjmjohnson opened this issue Jul 13, 2020 · 9 comments
Closed
18 tasks done

ENH: Configure PyPi API Tokens For ITK Remote Modules: Part 1 #1921

hjmjohnson opened this issue Jul 13, 2020 · 9 comments
Assignees
Labels
type:Style Style changes: no logic impact (indentation, comments, naming)

Comments

@hjmjohnson
Copy link
Member

hjmjohnson commented Jul 13, 2020

Description

We have completed about 1/2 of the repositories.

This issue details ITK's remote repositories requiring a PyPi API token generated to allow deployment from GitHub Actions. Essentially, @mseng10 will be iterating through the remote modules and contacting @hjmjohnson to complete the following steps extracted from ITK's issue here. Below are the steps that must be completed for each package:

1.Contact @thewtex, @dzenanz about Python package name, who will add @hjmjohnson, @dzenanz, @thewtex, ??? to the maintainer list on PyPI.

  1. Create an API token on PyPI for the package, and puts in the repository Settings -> Secrets under the key pypi_password.
  2. Create new Git tag, either locally and pushing, or in the GitHub web Release page, this will trigger builds and push the packages to PyPI.

Below is a TODO list of repositories that are completed and need the token generated for its respective module.
The name of the ITK Python Package that must be discussed with Matt McCormick. When the steps are complete, @johnsonhj will notify @mseng

  • Module_PerformanceBenchmarking
  • Module_MGHIO
  • Module_GenericLabelInterpolation
  • Module_Cuberille
  • Module_AnalyzeObjectMapIO
  • Module_AnisotropicDiffusionLBR
  • Module_BioCell
  • Module_BoneMorphometry
  • Module_IOMeshSTL
  • Module_MinimalPathExtraction
  • Module_MultipleImageIterator
  • Module_ParabolicMorphology
  • Module_TextureFeatures
  • Module_TwoProjectionRegistration
  • Module_Montage
  • Module_MeshNoise
  • Module_SubdivisionQuadEdgeMesh
  • Module_IOScanco

Expected coding style

PyPi automated generation completed by CI.

Actual coding style

Final CI integration steps needed

Versions

@hjmjohnson hjmjohnson added the type:Style Style changes: no logic impact (indentation, comments, naming) label Jul 13, 2020
@hjmjohnson hjmjohnson assigned thewtex, mseng10 and dzenanz and unassigned thewtex Jul 13, 2020
@thewtex
Copy link
Member

thewtex commented Jul 13, 2020

@hjmjohnson @dzenanz what are your PyPI account names?

@dzenanz
Copy link
Member

dzenanz commented Jul 13, 2020

I just created: https://pypi.org/user/dzenanz/

@hjmjohnson
Copy link
Member Author

Notes from @mseng10

itk-bsplinegradient: This module needs the tag created in Web Release history as it has already been merged.
itk-higherorderaccurategradient: This module can have it's tag created through a PR using this branch. If you want a template for the PR just copy this.
itk-simpleitkfilters: This module can have it's tag created through a PR using this branch.
itk-fixedpointinversedisplacementfield: This module can have it's tag created through a PR using this branch.

NOTE: For itk-simpleitkfilters and itk-fixedpointinversedisplacementfield these modules did not have any packages published to PyPi (that I could see). When discussing with Matt McCormick please mention this as a package may have to be created by him.

itk-labelerodedilate: This module can have it's tag created through a PR using this branch
itk-iofdf: This module can have it's tag created through a PR using this branch
itk-skullstripping: This module can have it's tag created through a PR using this branch

Repositories with published PyPi packages
itk-thickness3d: This module can have it's tag created through a PR using this branch
itk-strain: This module can have it's tag created through a PR using this branch
itk-principalcomponentsanalysis: This module can have it's tag created through a PR using this branch
itk-polartransform: This module can have it's tag created through a PR using this branch
itk-phasesymmetry: This module can have it's tag created through a PR using this branch

@hjmjohnson
Copy link
Member Author

I also created a pypi account:

https://pypi.org/user/hjmjohnson/

@mseng10
Copy link
Contributor

mseng10 commented Jul 14, 2020

@thewtex @hjmjohnson @dzenanz
I believe there was a miscommunication on my end. The modules listed in the Description (PerformanceBenchmarking through IOScanco) have already been completed and need no further actions. This new TODO list contains all the modules that are completed and need authorized actions. I have linked my forked branch for each of the modules, so all that should be required is a PR with proper authorization.

  • itk-bsplinegradient: This module needs the tag created in Web Release history as it has already been merged. MM: Tag here
  • itk-higherorderaccurategradient: This module can have it's tag created through a PR using this branch. MM: PR here
  • itk-simpleitkfilters: This module can have it's tag created through a PR using this branch. MM: PR here
  • itk-fixedpointinversedisplacementfield: This module can have it's tag created through a PR using this branch.
  • itk-labelerodedilate: This module can have it's tag created through a PR using this branch
  • itk-iofdf: This module can have it's tag created through a PR using this branch
  • itk-skullstripping: This module can have it's tag created through a PR using this branch
  • itk-thickness3d: This module can have it's tag created through a PR using this branch
  • itk-strain: This module can have it's tag created through a PR using this branch
  • itk-principalcomponentsanalysis: This module can have it's tag created through a PR using this branch
  • itk-polartransform: This module can have it's tag created through a PR using this branch
  • itk-phasesymmetry: This module can have it's tag created through a PR using this branch
  • itk-morphologicalcontourinterpolation: This module can have it's tag created through a PR using this branch
  • itk-smoothingrecursiveyvvgaussianfilter: This module can have it's tag created through a PR using this branch

NOTE: itk-labelerodedilate, itk-iofdf, itk-skullstripping, itk-fixedpointinversedisplacementfield, itk-simpleitkfilters DO NOT have their packages published to PyPi (that I could find). They will likely need an initial creation in PyPi.

@thewtex
Copy link
Member

thewtex commented Jul 15, 2020

The following have the CI, API Token, Multi-PyPI collaborators setup:

  • itk-genericlabelinterpolator
  • itk-cuberille
  • itk-anisotropicdiffusionlbr
  • itk-bonemorphometry
  • itk-iomeshstl
  • itk-minimalpathextraction
  • itk-parabolicmorphology
  • itk-texturefeatures
  • itk-twoprojectionregistration
  • itk-montage
  • itk-meshnoise
  • itk-subdivisionquadedgemeshfilter
  • itk-ioscanco
  • itk-bsplinegradient
  • itk-higherorderaccurategradient
  • itk-simpleitkfilters
  • itk-thickness3d

@mseng10
Copy link
Contributor

mseng10 commented Nov 20, 2020

@thewtex I have gone through and fixed the following branches to have the recent changes from the ITKModuleTemplate. These modules are ready to have GitHub Actions enabled.

  • itk-fixedpointinversedisplacementfield: This module can have it's tag created through a PR using this branch.
  • itk-labelerodedilate: This module can have it's tag created through a PR using this branch
  • itk-iofdf: This module can have it's tag created through a PR using this branch
  • itk-skullstripping: This module can have it's tag created through a PR using this branch
  • itk-strain: This module can have it's tag created through a PR using this branch
  • itk-principalcomponentsanalysis: This module can have it's tag created through a PR using this branch
  • itk-polartransform: This module can have it's tag created through a PR using this branch
  • itk-phasesymmetry: This module can have it's tag created through a PR using this branch
  • itk-smoothingrecursiveyvvgaussianfilter: This module can have it's tag created through a PR using this branch

@thewtex
Copy link
Member

thewtex commented Nov 26, 2020

@mseng10 marvelous! Old CI services have been disabled, PyPI tokens have been created, @hjmjohnson @dzenanz were added as admins, and PyPI tokens were created for all the noted packages.

@thewtex thewtex closed this as completed Nov 26, 2020
@mseng10
Copy link
Contributor

mseng10 commented Nov 26, 2020

@thewtex Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Development

No branches or pull requests

4 participants