-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional country - Finland #56
Comments
I added Finland to the version 1 of the model in a quick and dirty way last week. Based on that:
For version 1, there were also some minor code changes required for it to support 12 countries. I'll send a mail to your assumed (Finnish) work e-mail address from my work e-mail! |
Do so! See mansmagnusson.com for contact info. |
Hi @MansMeg and @elmokki, good job. We are currently not in a position to independently add countries. For countries to be added we need to make sure all of our assumptions and data match. I am happy for you guys to work independently but work for a new country can't be just added because we also want to make sure IFR and age distribution we use are correct and verified. |
Ok, so how do we help you to do this verification. We are working with this from Finland so we could do the verification you need, I suppose? Thats why I had these questions above. |
It is mainly working with the people who have better understanding of estimating IFR from contact matrices and other is how much data is really there to estimate with confidence. |
Would you happen to have a reference for estimating IFR from contact matrices? I'm very interested in getting the best possible estimates regardless of whether they'd be added here, and that's the part there wasn't code or thorough documentation for. |
Hi @elmokki as it is said in the report we are using verity.et.al as our reference for IFR and contact matrices. Just that when the paper doesn't really have it for a country, we talk to them and work with them to get it correct; as they understand it more than we do. |
@s-mishra thanks! I seem to have missed that reference. I'll look into it! |
I do think I can actually do that estimation, if you are interested. Or are you in contact with others in Finland currently? Although, I have no intention to push this if you are not interested. It was just that it was explicitly stated that you welcomed additional countries as contributions. |
Sorry, I missed the last comment. So if I understand it correctly, the popt_ifr file contains values of ifr from the verity et al paper. If they dont have the estimate, they need to supply it to you for you to be able to include another country? |
Hi @MansMeg, sorry if I sounded rude. I am just saying even if you do the update we might not be able to get it in the main branch without going through it in detail. However, if everything works we will add. I just need to see Finland data to be sure we can act on it. |
No problem, I fully understand that you would not blindly accept a PR from random people. So, as mentioned, we are multiple people that want to include this for Finland. I suggest we do that and open a PR. Then you can look at it when you have time. For us to add Finland for our sake, we need to know:
In the PR:
|
Is your feature request related to a problem? Please describe.
We are currently working on including Finnish data in the model. We would be happy to contribute this to your repo. How should we do that in the best way?
Describe the solution you'd like
I would need information on what files (csv) needs to be updated and how. ECDC data already have death counts for Finland, so that is already handled.
I guess the following files need to be updated:
With kind regards
Måns
The text was updated successfully, but these errors were encountered: