Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorPicker in GDI Rendring #620

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Tropby
Copy link

@Tropby Tropby commented Mar 10, 2024

I have fixed a problem with the ColorPicker in GDI rendering.

Copy link
Contributor

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to bring this in. Anyone else care for a review?

@@ -389,7 +389,7 @@ extern "C" {
#define NK_POINTER_TYPE unsigned __int32
#elif defined(__GNUC__) || defined(__clang__)
#if defined(__x86_64__) || defined(__ppc64__) || defined(__PPC64__) || defined(__aarch64__)
#define NK_POINTER_TYPE unsigned long
#define NK_POINTER_TYPE unsigned long long
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in nuklear.h will have to be replicated in the src directory too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about changing this as part of the GDI demo updates. Going to recommend pushing that to a different change request.

Suggested change
#define NK_POINTER_TYPE unsigned long long
#define NK_POINTER_TYPE unsigned long

@@ -374,7 +374,7 @@ extern "C" {
#define NK_SIZE_TYPE unsigned __int32
#elif defined(__GNUC__) || defined(__clang__)
#if defined(__x86_64__) || defined(__ppc64__) || defined(__PPC64__) || defined(__aarch64__)
#define NK_SIZE_TYPE unsigned long
#define NK_SIZE_TYPE unsigned long long
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define NK_SIZE_TYPE unsigned long long
#define NK_SIZE_TYPE unsigned long

Comment on lines +679 to +681
/// TODO: 'IStream' {aka 'struct IStream'} has no member named 'lpVtbl'GCC
stream->Release();
//stream->lpVtbl->Release(stream);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a remaining TODO?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants