Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IgxTreeGrid multipleCascade selection + filtering scenario - sibling records get implicitly deselected #13762

Closed
ddaribo opened this issue Dec 15, 2023 · 1 comment · Fixed by #13822, #13825 or #13824
Assignees
Labels
🐛 bug Any issue that describes a bug grid: row-selection grid: tree-grid version: 16.1.x version: 17.0.x version: 17.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@ddaribo
Copy link
Contributor

ddaribo commented Dec 15, 2023

Description

The current behavior of the multipleCascade selection is such that the parent's selected state is determined based on the filtered-in children, in case of applied filtering conditions.
However, the result of performing the below listed steps might not quite be expected, as this behavior would cause non filtered-in sibling records' selections state to get implicitly changed.

  • igniteui-angular version: any
  • browser: any

Steps to reproduce

  1. Open this demo from the Tree Grid Row Selection topic.
  2. Choose 'Cascade' selection mode.
  3. Select the first two child records of "Name: Johnathan Winchester"' - "Michael Burke" and "Thomas Anderson".
  4. Filter the "Name" column by entering "bu" in the filter input - only the "Michael Burke" child remains.
  5. Observe the Parent record checkbox state - it changes from indeterminate to checked since now all its visible children are selected.
  6. The tree.selectedRows property could also be observed in the console - the currently selected records IDs are [1, 2, 3].
  7. Now deselect the "Michael Burke" record -> both child and parent become deselected, because none of the filtered-in children of the parent are now selected.
  8. Clear the filter.

Result

No selected records remain at this point, despite not having explicitly deselected the "Thomas Anderson" record.

Expected result

The non-filtered child record not to get deselected. It should become deselected only by explicitly deselecting it, or by deselecting its parent record, provided the child is within the currently filtered-in records.

Attachments

tree-grid-2

@Glopter
Copy link

Glopter commented Jan 18, 2024

Hello. Can anyone give a rough estimate of when work will start here?

@ddaribo ddaribo self-assigned this Jan 19, 2024
@ddaribo ddaribo added 👀 status: in-review Issue is currently being reviewed 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new 👀 status: in-review Issue is currently being reviewed labels Jan 19, 2024
@ddaribo ddaribo added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment