Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance base input validation #184

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Enhance base input validation #184

merged 2 commits into from
Aug 10, 2023

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Aug 10, 2023

No description provided.

@nilmerg nilmerg added the bug Something isn't working label Aug 10, 2023
@nilmerg nilmerg added this to the v0.9.0 milestone Aug 10, 2023
@nilmerg nilmerg self-assigned this Aug 10, 2023
@cla-bot cla-bot bot added the cla/signed label Aug 10, 2023
This has been only partially implemented using the `data-manage-required`
attribute. But now I don't think this is even required as the client
knows very well when input is required or not.
The current terms, if any, are set as json on the input. Though,
if there are none, the input was not reset and the previous json
was submitted again.
@nilmerg nilmerg force-pushed the enhance-base-input-validation branch from e644abe to 20afc0e Compare August 10, 2023 10:37
@nilmerg nilmerg merged commit f515e9a into main Aug 10, 2023
6 of 12 checks passed
@nilmerg nilmerg deleted the enhance-base-input-validation branch August 10, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant