From fdb8771febf2bfe5dd2b9dd86071dcdf9c87193d Mon Sep 17 00:00:00 2001 From: Sukhwinder Dhillon Date: Fri, 19 Jul 2024 11:31:16 +0200 Subject: [PATCH] Wip: todos and bugs to fix --- asset/js/widget/ActionList.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/asset/js/widget/ActionList.js b/asset/js/widget/ActionList.js index 3105dd1f..dd4e4901 100644 --- a/asset/js/widget/ActionList.js +++ b/asset/js/widget/ActionList.js @@ -90,7 +90,7 @@ define(["../notjQuery"], function ($) { onClick(event) { let target = event.currentTarget; - if (target.matches('a') && (! target.matches('.subject') || event.ctrlKey || event.metaKey)) { + if (target.matches('a') && (! target.matches('.subject') || event.ctrlKey || event.metaKey)) { //TODO: don't use icinga specific classes return true; } @@ -169,6 +169,7 @@ define(["../notjQuery"], function ($) { if (! this.isMultiSelectable || ! this.isPrimary) { return; } + //TODO: remove icinga specific classes, make this function more generic let activeItemCount = this.getActiveItems().length; let footer = this.list.closest('.container').querySelector('.footer'); @@ -534,6 +535,8 @@ define(["../notjQuery"], function ($) { * @param detailUrl */ load(detailUrl = null) { + //TODO: somehow item is deselected when req is canceled and new req is started + //isProcessing is not working as expected if (! detailUrl) { let activeItems = this.getActiveItems(); if (activeItems.length) {