Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke-IcingaCheckUpdates: Output is confusing #344

Open
log1-c opened this issue May 2, 2023 · 1 comment
Open

Invoke-IcingaCheckUpdates: Output is confusing #344

log1-c opened this issue May 2, 2023 · 1 comment

Comments

@log1-c
Copy link

log1-c commented May 2, 2023

Hello :)

I updated the plugins to v1.10.1 recently and find the short message output of the plugin a bit confusing.
image
image

The output "Windows Updates: 6 OK" leads me to think that there are 6 updates available for this machine, and that that is "OK".

Though by now I figured out that the "6" refers to the 6 categories (summary, reboot, other, security, defender, rollups) I would still not suggest this output.
And (imo) it gets worse/more confusing with threshold breaches
image

Suggestion: Don't display any numbers in the short message. Or add something like "category".
OK: [OK] Windows Updates below thresholds
CRITICAL/WARNING: [CRITICAL/WARNING] Windows Update Categories: 2 CRITICAL, 1 Warning, 5 OK (comma-separation)

Also I would suggest omitting the c unit in the text output.
image

Best
log1c

@mantis
Copy link

mantis commented May 3, 2023

Well also, if there are updates available in the pending restart state, it seems you get no warning:

image

unless you specify WarnOnReboot:

image

image

Now, I'd probably be inclined to say that the Warning state is wrong here - if an update is installed and the server has been restarted = OK, it's live and secure.

if an update is not installed, then that's BAD.
if an update has been installed and is not active (e.g. server needs a reboot) - then that's BAD. I'd understand if this state was only a warning - but it shouldn't be a good(OK) state to be in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants