Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix all precommit errors #63

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix: Fix all precommit errors #63

merged 1 commit into from
Jun 24, 2024

Conversation

TjazVracko
Copy link
Collaborator

Description

Fix all precommit errors after enabling pre-commit

Areas of interest for the reviewer

/

Checklist

  • My code follows the style guidelines as defined by IRNAS.
  • I have performed a self-review of my code.
  • My changes generate no new warnings.
  • I added/updated source code documentation for all newly added or changed functions.
  • I updated all customer-facing technical documentation. - This PR
    introduced only internal facing changes.

After-review steps

  • I will merge PR by myself.

Copy link
Collaborator Author

TjazVracko commented Jun 18, 2024

Copy link

Coverage after merging fix/precommit-errors into fix/tests will be

23.76%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
library/protocol/binary
   user_settings_protocol_binary.c83.33%72.97%100%87.18%113, 116–118, 118, 118–119, 121–124, 135–136, 173–174, 66–67, 71–72, 80
library/user_settings
   user_settings.c49.43%31.51%72.92%60.66%100, 107, 131–132, 137–138, 138, 138–141, 141, 141–142, 145, 168, 176–177, 177, 177–178, 183–184, 184, 184–185, 190–191, 191, 191–192, 197–198, 198, 198–199, 209–211, 218–219, 227, 233–234, 234, 234–235, 240–241, 241, 241–242, 247–248, 248, 248–249, 259, 259, 259, 265, 265, 271, 271, 278–279, 279, 279–280, 290–291, 291, 291–292, 297–298, 298, 298–299, 305, 307, 307, 307, 309–310, 310, 310, 312, 317, 317, 317, 320, 320, 320, 335, 341, 351–352, 352, 352–353, 359–360, 360, 360–361, 369, 375, 375, 381, 390–391, 391, 391–392, 397–398, 398, 398–399, 404–405, 405, 405–406, 415–416, 423, 425, 425, 425, 431, 433, 433, 433–434, 436, 438, 440, 440, 440, 442–443, 443, 443, 445–446, 451, 451, 451, 454, 454, 454, 462, 47, 470, 470, 470, 478, 48, 481, 488, 491, 498, 505, 505, 505–506, 506, 506–507, 509, 512, 515, 517, 517, 517, 519, 52, 520, 520, 520, 522, 527, 53, 530, 537–538, 544, 547, 549, 549, 549, 551–552, 552, 552, 554, 559, 559, 559, 562, 562, 562, 569, 574, 576, 576, 576, 578–579, 579, 579, 58, 581–582, 586, 589, 59, 59, 59, 595, 597, 597, 597, 599, 60, 600, 600, 600, 602, 606, 608, 608, 608, 61, 610–611, 611, 611, 613, 616, 618, 618, 618, 62, 62, 62, 620–621, 621, 621, 623, 626, 628, 628, 628, 630–631, 631, 631, 633, 638, 638, 638, 64, 641, 641, 641, 648, 648, 648, 651, 651, 651, 656, 658, 658, 658, 660–661, 661, 661, 663, 668, 668, 668, 671, 671, 671, 678, 681, 688, 688, 688, 691, 691, 691, 732, 734, 734, 734, 736–737, 737, 737, 739–740, 742, 744, 744, 744, 746–747, 747, 747, 749–750, 754, 754, 754, 757, 757, 757, 764, 764, 764, 767, 767, 767, 774, 83–84, 88–89, 94–95, 95, 95–98, 98, 98
   user_settings_json.c48.34%39.22%100%52.44%100–101, 103, 106, 114, 127–128, 128, 128–129, 133–134, 143–144, 160, 160, 160, 160, 160, 160, 160, 160, 162, 165, 169–171, 173–175, 181–183, 185–187, 189–191, 193–195, 197–199, 216–217, 217, 217, 221–222, 222, 222–224, 235, 243, 246–247, 247, 247–248, 252–253, 253, 253–254, 261–262, 262, 262–264, 264, 264–265, 276–278, 286, 300–302, 311, 41, 41, 41, 41, 41, 41, 41, 41, 43, 49–50, 50, 50–52, 54, 56–57, 57, 57–59, 61, 64, 70–71, 71, 71–73, 75, 77–78, 78, 78–80, 82, 84–85, 85, 85–87, 89, 91–92, 92, 92–94, 96, 98–99, 99, 99
   user_settings_list.c89.13%80.77%100%93.42%102, 125, 134, 145, 180, 36, 36, 36, 47, 49–50, 52, 56, 72, 93
modules/lib/cjson
   cJSON.c14.37%13.41%22.13%14.33%1000–1004, 1006–1008, 1012–1013, 1015,

Copy link
Collaborator Author

TjazVracko commented Jun 24, 2024

Merge activity

  • Jun 24, 4:57 AM EDT: @TjazVracko started a stack merge that includes this pull request via Graphite.
  • Jun 24, 5:06 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 24, 5:07 AM EDT: @TjazVracko merged this pull request with Graphite.

@TjazVracko TjazVracko changed the base branch from fix/tests to main June 24, 2024 09:04
@TjazVracko TjazVracko merged commit 46c8c57 into main Jun 24, 2024
3 of 4 checks passed
Copy link

Coverage after merging fix/precommit-errors into main will be

23.76%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
library/protocol/binary
   user_settings_protocol_binary.c83.33%72.97%100%87.18%113, 116–118, 118, 118–119, 121–124, 135–136, 173–174, 66–67, 71–72, 80
library/user_settings
   user_settings.c49.43%31.51%72.92%60.66%100, 107, 131–132, 137–138, 138, 138–141, 141, 141–142, 145, 168, 176–177, 177, 177–178, 183–184, 184, 184–185, 190–191, 191, 191–192, 197–198, 198, 198–199, 209–211, 218–219, 227, 233–234, 234, 234–235, 240–241, 241, 241–242, 247–248, 248, 248–249, 259, 259, 259, 265, 265, 271, 271, 278–279, 279, 279–280, 290–291, 291, 291–292, 297–298, 298, 298–299, 305, 307, 307, 307, 309–310, 310, 310, 312, 317, 317, 317, 320, 320, 320, 335, 341, 351–352, 352, 352–353, 359–360, 360, 360–361, 369, 375, 375, 381, 390–391, 391, 391–392, 397–398, 398, 398–399, 404–405, 405, 405–406, 415–416, 423, 425, 425, 425, 431, 433, 433, 433–434, 436, 438, 440, 440, 440, 442–443, 443, 443, 445–446, 451, 451, 451, 454, 454, 454, 462, 47, 470, 470, 470, 478, 48, 481, 488, 491, 498, 505, 505, 505–506, 506, 506–507, 509, 512, 515, 517, 517, 517, 519, 52, 520, 520, 520, 522, 527, 53, 530, 537–538, 544, 547, 549, 549, 549, 551–552, 552, 552, 554, 559, 559, 559, 562, 562, 562, 569, 574, 576, 576, 576, 578–579, 579, 579, 58, 581–582, 586, 589, 59, 59, 59, 595, 597, 597, 597, 599, 60, 600, 600, 600, 602, 606, 608, 608, 608, 61, 610–611, 611, 611, 613, 616, 618, 618, 618, 62, 62, 62, 620–621, 621, 621, 623, 626, 628, 628, 628, 630–631, 631, 631, 633, 638, 638, 638, 64, 641, 641, 641, 648, 648, 648, 651, 651, 651, 656, 658, 658, 658, 660–661, 661, 661, 663, 668, 668, 668, 671, 671, 671, 678, 681, 688, 688, 688, 691, 691, 691, 732, 734, 734, 734, 736–737, 737, 737, 739–740, 742, 744, 744, 744, 746–747, 747, 747, 749–750, 754, 754, 754, 757, 757, 757, 764, 764, 764, 767, 767, 767, 774, 83–84, 88–89, 94–95, 95, 95–98, 98, 98
   user_settings_json.c48.34%39.22%100%52.44%100–101, 103, 106, 114, 127–128, 128, 128–129, 133–134, 143–144, 160, 160, 160, 160, 160, 160, 160, 160, 162, 165, 169–171, 173–175, 181–183, 185–187, 189–191, 193–195, 197–199, 216–217, 217, 217, 221–222, 222, 222–224, 235, 243, 246–247, 247, 247–248, 252–253, 253, 253–254, 261–262, 262, 262–264, 264, 264–265, 276–278, 286, 300–302, 311, 41, 41, 41, 41, 41, 41, 41, 41, 43, 49–50, 50, 50–52, 54, 56–57, 57, 57–59, 61, 64, 70–71, 71, 71–73, 75, 77–78, 78, 78–80, 82, 84–85, 85, 85–87, 89, 91–92, 92, 92–94, 96, 98–99, 99, 99
   user_settings_list.c89.13%80.77%100%93.42%102, 125, 134, 145, 180, 36, 36, 36, 47, 49–50, 52, 56, 72, 93
modules/lib/cjson
   cJSON.c14.37%13.41%22.13%14.33%1000–1004, 1006–1008, 1012–1013, 1015,

@TjazVracko TjazVracko deleted the fix/precommit-errors branch June 24, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant