Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add jq dependency #5

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: add jq dependency #5

merged 1 commit into from
Sep 24, 2024

Conversation

Finwood
Copy link
Contributor

@Finwood Finwood commented Sep 16, 2024

Description

The image was missing the jq utility, which is required by the codechecker-diff.sh script in firmware repositories.

image

Areas of interest for the reviewer

Nothing special.

Checklist

  • My code follows the style guidelines as defined by IRNAS.
  • I have performed a self-review of my code.
  • My changes generate no new warnings.
  • I added/updated source code documentation for all newly added or changed functions. No new or changed functions.
  • I updated all customer-facing technical documentation. not applicable

After-review steps

  • Reviewer can merge and delete the branch.

The codechecker-diff.sh script in firmware repositories depends on the
jq tool to extract information from the `codecheckerfile.json`.
@MarkoSagadin
Copy link
Collaborator

Thank you for catching this. I will also add this as a dependency to the ncs-zephyr image, I see that we are also missing it there.

@MarkoSagadin
Copy link
Collaborator

I will make a new release of the images today, you should try to pull the new latest and give it a try.

@MarkoSagadin MarkoSagadin merged commit 374f6d7 into IRNAS:main Sep 24, 2024
1 check failed
@Finwood
Copy link
Contributor Author

Finwood commented Sep 24, 2024

All fixed, CodeChecker works 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants