forked from Field-Robotics-Lab/dave
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multibeam Sonar Migration Template #15
Open
woensug-choi
wants to merge
46
commits into
ros2
Choose a base branch
from
sonar_ws_progress
base: ros2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…the dvl topic name from sdf
…rd-Down 2. Enabled water tracking mode
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fastforward the effort the migration of the Muiltibeam Sonar plugin.
Notion note related to this is at https://yeongdocat.notion.site/Multibeam-Sonar-Plugin-Migration-Memo-3a98b778e87a419b9adf32a88d78814c?pvs=4
Example Launch Command with
ros_gz_bridge
to translate gz msg to ROS msgros_gz_bridge
is not updated for new sensors in new ros-gazebo pair yetExample Launch Command with
dave_sensor.launch.py
Progress (Check date of the update, I am updating this as I progress)
ros2 launch dave_demos dave_world.launch.py world_name:=dave_multibeam_sonar verbose:=true
ros2 launch dave_demos multibeam_sonar_standalone.launch.py x:=4.0 z:=0.5 Y:=3.14
point cloud
- RosGzPointCloud Not Loading gazebosim/ros_gz#549 (comment)
- Something is very wrong when trying to view point cloud at current state
- So many tutorials in
ros_gz_sim_demo
just doesn't work, butros2 launch ros_gz_sim_demos gpu_lidar_bridge.launch.py
works!- This uses GPULidar sensor. I would try remove all Acoustic Beam parts and hard insert GPU Lidar Code as it is to visualize point cloud correctly
Leftover
Float_V
is for