Revert "Update to newest owltools to align OWL API with ROBOT 1.9.6" #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 716a6b6.
gouttegd
approved these changes
Jun 25, 2024
balhoff
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
@matentzn this is fine for now, although I have made a few more changes to owltools to correct the problems we saw. But I don't have time this week to thoroughly test it. I expect we will need the owltools update for GO. We can use our own copy if need be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 716a6b6.
For now, it its better for the stability of pipelines that depend on owltools such as Mondo, Uberon to stick with the older version of owltools. These pipeline require to process owtools generated obo format for example with perl scripts and many other "ad hoc" scripts, and even small serialisation changes cause us problem now.
@balhoff we would prefer to freeze the owltools in time, and move everything to ROBOT now. Could you make an issue that shows the "garbage encountered in the GO pipeline" so we can think of a better solution for this?