Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default of base_merge_drop_equivalent_class_axioms #1020

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Mar 2, 2024

This is a temporary fix.

@dosumis wanted us to add "equivalent class removal" as a default to ODK, and in principle, we all agreed.

However, there is this is the fundamental issue:

  1. we can only drop equivalent class axioms if we have a “true base”, i.e. the subclass axioms are asserted
  2. we do not have true base yet - because its shipped the next ODK 1.5.

To not break everything everywhere with the new ODK release, we discussed to make this feature opt-in for now, and document it a bit bettter.

@matentzn matentzn requested a review from gouttegd March 2, 2024 14:24
@matentzn matentzn merged commit c675890 into master Mar 2, 2024
1 check passed
@matentzn matentzn deleted the base-merge-drop branch March 2, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants