Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotenv requirement #1110

Open
twhetzel opened this issue Oct 23, 2024 · 1 comment
Open

Add dotenv requirement #1110

twhetzel opened this issue Oct 23, 2024 · 1 comment

Comments

@twhetzel
Copy link

I am working with a repo that uses an API Key from a .env file, however when I run make commands for the repo I get "ModuleNotFoundError: No module named 'dotenv'". Can dotenv be added into ODK?

@gouttegd
Copy link
Contributor

gouttegd commented Oct 23, 2024

Looking at your omim2obo script, I believe you actually need python-dotenv rather than dotenv -- only the former provides a dotenv_values symbol.

And python-dotenv is already in the ODK since version 1.5, released earlier this year.

I also see your run.sh script uses the ODK 1.4.3 by default, which explains why you get that error -- python-dotenv is not present in that version.

Is there a compelling reason why you must keep using the 1.4 branch? Have you encountered any issue with ODK 1.5?

The ODK policy is to maintain only one branch active at any time, so we are no longer supporting the 1.4 branch since ODK 1.5 has been released -- I am not keen on making an exception and releasing a 1.4.4 just to add a single package needed by one project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants