Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document instructions for running the obographs-compliance suite #751

Open
matentzn opened this issue May 5, 2024 · 4 comments
Open

Document instructions for running the obographs-compliance suite #751

matentzn opened this issue May 5, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@matentzn
Copy link
Contributor

matentzn commented May 5, 2024

@cmungall can you provide a page docs page on how to use the obographs compliance framework?

We are close to a robot release and we need this merged now:

ontodev/robot#1198

The first in a two stage process towards some important obographs extensions.

@matentzn matentzn added the documentation Improvements or additions to documentation label May 5, 2024
@cmungall
Copy link
Collaborator

cmungall commented May 6, 2024 via email

@matentzn
Copy link
Contributor Author

matentzn commented May 6, 2024

But the doc strings are not too bad Claude could do a good first
pass. See also the open PR to get a sense of the diffs

Maybe just two bullet points when you have a minute. Like:

  1. Put robot binary on path
  2. Run test suite with poetry run tox -e py

@cmungall
Copy link
Collaborator

cmungall commented May 6, 2024

Unfortunately it's not so simple. You really have to read the full docs right now. There is no established SoT now. The tests involve a bootstrapping component. It looks like there have been some changes since this was first done. For example, as can be seen in #747 the owlapi now injects labels for oio APs. This is a change from the baseline that was previously established. So we need to discuss whether injection of these labels is the new standard and update the obo-syntax docs and regenerate the baseline, or we need to declare the current behavior as in violation

@cmungall
Copy link
Collaborator

OK, to keep it simple I have just accepted that it is now the standard that conversion introduces AP label injections.

So the instructions are simple:

  1. Make sure the version of robot you want to test is on the command line
  2. Run the test using pytest or your IDE

If the output doesn't conform, it will fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants