Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update descriptions of ClassCreation and ObjectPropertyCreation #83

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nlharris
Copy link

@nlharris nlharris commented Sep 5, 2024

Updating ClassCreation description as per @cmungall's suggestion. I guessed at how to update the description for ObjectPropertyCreation; not sure I got it right.

Fixed a few minor typos I noticed.

BTW, I do not understand these comments (which appeared twice starting at line 928):

  • if a node obsoletion C, C about N1, and C has direct replacement N2, and there exists an edge with an edge property referencing N1, it is possible to replace with N2
  • if a node obsoletion C C about N1, and C has direct replacement N2, then N1 IAO:0100001 N2

(Mostly I don't understand "C about N1". Should "about" be some other word?)

Updating ClassCreation description as per @cmungall's suggestion. I guessed at how to update the description for ObjectPropertyCreation; not sure I got it right.

Fixed a few minor typos I noticed.

BTW, I do not understand these comments (which appeared twice starting at line 928):

 - if a node obsoletion C, C about N1, and C has direct replacement N2, and there
      exists an edge with an edge property referencing N1, it is possible to replace
      with N2
    - if a node obsoletion C C about N1, and C has direct replacement N2, then N1 IAO:0100001
      N2

(Mostly I don't understand "C about N1". Should "about" be some other word?)
I didn't realize that was a syntax error
@nlharris
Copy link
Author

nlharris commented Sep 5, 2024

I fixed the syntax error that was making a test fail - how do I get it to rerun the checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant