Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove x_representation fields #68

Open
cmungall opened this issue Mar 21, 2024 · 1 comment
Open

Remove x_representation fields #68

cmungall opened this issue Mar 21, 2024 · 1 comment
Milestone

Comments

@cmungall
Copy link
Contributor

changes be like

{
  "id": "CHANGE:001",
  "type": "NodeRename",
  "old_value": "'nuclear envelope'",
  "new_value": "'foo bar'",
  "about_node": "GO:0005635",
  "about_node_representation": "curie",
  "@type": "NodeRename"
}

there is no need for about_node_representation if we have a prefix map for each change set.

@hrshdhgd
Copy link
Collaborator

hrshdhgd commented Mar 22, 2024

It is derived from get_entity_representation() which is sprinkled all over the project. I'll need more clarification as to where it's needed and where not. This seems to be in place since a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants