Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The change_date slot should be date-typed #50

Open
gouttegd opened this issue Feb 8, 2024 · 0 comments
Open

The change_date slot should be date-typed #50

gouttegd opened this issue Feb 8, 2024 · 0 comments
Milestone

Comments

@gouttegd
Copy link

gouttegd commented Feb 8, 2024

The change node has a change_date slot, supposedly intended to represent the date when a change was created.

That slot has no explicit range:

slots:
  […]
  change_date:
    slot_uri: dcterms:date
  […]

so it defaults to be string-typed, which doesn’t seem to make much sense. It should have a range of xsd:date (or possibly xsd:dateTime to allow finer granularity than a day) instead.

Related: I’m unsure what to make of the following comment in the slot_usage section:

change_date:
  comments:
  - This should be the composition of 'was generated by' and 'ended at time'

What does that mean? Is that why the slot is not date-typed? Is the slot supposed to contain a string representation of a more complex structure?

@cmungall cmungall added this to the 1.0.0 release milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants