Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validator-core - add support for curved geometries #232

Closed
3 tasks done
mborne opened this issue Jul 12, 2021 · 0 comments · Fixed by #248
Closed
3 tasks done

validator-core - add support for curved geometries #232

mborne opened this issue Jul 12, 2021 · 0 comments · Fixed by #248
Assignees
@mborne
Labels
enhancement
Milestone
4.2

Comments

@mborne
Copy link
Collaborator

mborne commented Jul 12, 2021 •
edited
Loading

Problem

CURVEPOLYGON appears in PCRS datasets ( #231 ) and JTS can't read the corresponding WKT

Actions

Short term

  • v4.2.0 - Try to upgrade geotools and JTS to read them (note that it changes some digits in last decimals in DATA and validation report)
  • v4.2.1 - Add a GeometryReader class to use WKTReader2 by default instead of WKTReader as geotools extends JTS Geometry types to bring curved geometry support (see https://docs.geotools.org/stable/userguide/library/jts/geometry.html )
  • v4.2.1 - Ensure that there is no regression for GpU and DGPR (validator-regress-test)

Long term

Notes

  • WKTReader2 from geotools doesn't support dimension name after geometry type ("POINT Z ..."). A fallback to original WKTReader is added to avoid regressions. An interface GeometryFormat is mainly added to clarify naming and to allow other formats such as GeoJSON, WKB,... in the future.
@mborne mborne added this to the 4.1 milestone Jul 12, 2021
@mborne mborne changed the title validator-core - improve support for curve geometry types validator-core - improve or clarify support for curve geometry types Jul 12, 2021
@mborne mborne self-assigned this Jul 12, 2021
@mborne mborne modified the milestones: 4.1, 4.2 Jul 13, 2021
mborne added a commit that referenced this issue Jul 27, 2021
@mborne
pom.xml - upgrade geotools from 21.5 to 25.2 (refs #232)
2b0972f
@mborne mborne mentioned this issue Aug 2, 2021
Closed
12 tasks
@mborne mborne changed the title validator-core - improve or clarify support for curve geometry types validator-core - add support for curved geometries Aug 4, 2021
mborne added a commit that referenced this issue Aug 4, 2021
@mborne
add GeometryReader to avoid direct use of WKTReader from JTS (refs #232)
a603570
mborne added a commit that referenced this issue Aug 4, 2021
@mborne
validator-core - GeometryReader - add support for curved geometries u…
2dc5ee9 
…sing WKTReader2 from GeoTools (refs #232)
This was referenced Aug 4, 2021
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mborne mborne

Labels
enhancement
Projects
None yet
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

Issue 232 - add support for curved geometries IGNF/validator
1 participant
@mborne