-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add virtual points to tiles #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l points by tiles)
mdupaysign
force-pushed
the
add_virtual_points_to_tiles
branch
from
September 23, 2024 07:50
63f854f
to
ab695b5
Compare
gliegard
requested changes
Sep 23, 2024
lidro/create_virtual_point/vectors/run_add_virtual_points_by_tile.py
Outdated
Show resolved
Hide resolved
lidro/create_virtual_point/vectors/run_add_virtual_points_by_tile.py
Outdated
Show resolved
Hide resolved
mdupaysign
commented
Sep 24, 2024
gliegard
requested changes
Sep 25, 2024
# Clip virtual points file by LIDAR tiles | ||
# Create the tiling of lidar tiles | ||
json_tiles = os.path.join(output_dir, "tiles_from_las.GeoJSON") | ||
create_geojson_from_laz_files([os.path.join(input_dir, file) for file in os.listdir(input_dir)], json_tiles, crs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comme suggéré avant que tu fasses un main à part, ce serait plus lisible en deux lignes, avec une variable
laz_files = [os.path.join(input_dir, file) for file in os.listdir(input_dir)]
create_geojson_from_laz_files(laz_files, json_tiles, crs)
gliegard
requested changes
Sep 27, 2024
gliegard
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ajouter les points virtuels HYDRO à la dalles LIDAR