Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Torquetuner repository #1

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Update Torquetuner repository #1

wants to merge 12 commits into from

Conversation

aburt2
Copy link

@aburt2 aburt2 commented Nov 3, 2022

Add new torquetuner design and firmware to IDMIL torquetuner repository

@aburt2
Copy link
Author

aburt2 commented Nov 3, 2022

@ChristianFrisson ready to merge, updating the public repo with all the changes and updates we made to Torquetuner including the new firmware and hardware and some build guides

@ChristianFrisson
Copy link
Member

ChristianFrisson commented Nov 3, 2022

@aburt2 Excellent! Great work! Many updates!

Instead of commit add firmware and hardware from gitlab, remove git submodules, I think we should keep software dependencies as git submodules, but update them to the relevant sources, ie Moteus instead of Mechaduino-Firmware and a new mirror of TorqueTuner-ESP32 on IDMIL's github. What do you think about this?

(I can help do that if you need.)

@aburt2
Copy link
Author

aburt2 commented Nov 7, 2022

I guess we can do that, I don't have much experience with git submodules so I would need help with setting that up

@ChristianFrisson
Copy link
Member

ChristianFrisson commented Nov 10, 2022

Alright I'll prepare another pull request using your branch with commit e2247e2 rebased to use git submodules instead of copied files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants