-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI job for compatibility testing #1225
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
==========================================
- Coverage 76.84% 76.84% -0.01%
==========================================
Files 390 390
Lines 61924 61924
Branches 11400 11400
==========================================
- Hits 47586 47583 -3
- Misses 11871 11875 +4
+ Partials 2467 2466 -1 ☔ View full report in Codecov by Sentry. |
@andrewlee94 I think we now have only "good" failures, i.e. meaningful compatibility errors, as opposed to failures due to missing data files. |
@lbianchi-lbl Yes, those look like real failures now. I suspect a number of them are due to changes @eslickj made to the Helmholtz EoS packages, whilst a few are due to a known issue about changes I made to the metadata. |
@andrewlee94 FYI, these are the tests that are still failing after switching to IDAES/idaes-compatibility#9: |
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: