Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in modular properties bubble and dew point calculations #1212

Closed
andrewlee94 opened this issue Jun 22, 2023 · 2 comments · Fixed by #1213
Closed

Bug in modular properties bubble and dew point calculations #1212

andrewlee94 opened this issue Jun 22, 2023 · 2 comments · Fixed by #1213
Assignees
Labels
bug Something isn't working Priority:Normal Normal Priority Issue or PR property packages Issues dealing with properties user request Requests from external users

Comments

@andrewlee94
Copy link
Member

andrewlee94 commented Jun 22, 2023

A user brought up an issue in the support mailing list where they were trying to model a three phase system (VLS) with VLE (no solids equilibrium) and were seeing the incorrect VLE results if solids were present.

After digging into the model a little, I found that the dew point was changing depending on the solid concentration and looking at the dew point constraint I found that it uses the overall component mole fractions and thus the solids are incorrectly being included in those calculations. The fix will take some thought,

@andrewlee94 andrewlee94 self-assigned this Jun 22, 2023
@andrewlee94 andrewlee94 added bug Something isn't working user request Requests from external users Priority:Normal Normal Priority Issue or PR property packages Issues dealing with properties labels Jun 22, 2023
@lbianchi-lbl
Copy link
Contributor

Merging #977 might address part of the problem, but the underlying issue would still remain.

@lbianchi-lbl
Copy link
Contributor

lbianchi-lbl commented Jun 23, 2023

@andrewlee94 I've reopened #1176 and will be closing this under the assumption that #1213 was supposed to be linked to this issue. Feel free to reopen it if that's not the case. I see now that #1213 addresses... both? Should both #1212 and #1176 be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority:Normal Normal Priority Issue or PR property packages Issues dealing with properties user request Requests from external users
Projects
No open projects
Status: Done
2 participants