From f08c2989e4fef39c6c0db403daf2e75ca504838e Mon Sep 17 00:00:00 2001 From: Andrew Lee Date: Thu, 25 Jan 2024 14:29:52 -0500 Subject: [PATCH] Updating name of check_ill_conditioning --- idaes/core/util/model_diagnostics.py | 2 +- idaes/core/util/tests/test_model_diagnostics.py | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/idaes/core/util/model_diagnostics.py b/idaes/core/util/model_diagnostics.py index 2912c475ba..72b63520a9 100644 --- a/idaes/core/util/model_diagnostics.py +++ b/idaes/core/util/model_diagnostics.py @@ -3216,7 +3216,7 @@ def check_parallel_jacobian(model, tolerance: float = 1e-4, direction: str = "ro return parallel -def check_ill_conditioning( +def compute_ill_conditioning_certificate( model, target_feasibility_tol: float = 1e-06, ratio_cutoff: float = 1e-04, diff --git a/idaes/core/util/tests/test_model_diagnostics.py b/idaes/core/util/tests/test_model_diagnostics.py index 20d58359ab..3c9256844a 100644 --- a/idaes/core/util/tests/test_model_diagnostics.py +++ b/idaes/core/util/tests/test_model_diagnostics.py @@ -77,7 +77,7 @@ _write_report_section, _collect_model_statistics, check_parallel_jacobian, - check_ill_conditioning, + compute_ill_conditioning_certificate, ) from idaes.core.util.testing import _enable_scip_solver_for_testing @@ -3099,7 +3099,7 @@ def test_invalid_direction(self): match="Unrecognised value for direction \(foo\). " "Must be 'row' or 'column'.", ): - check_ill_conditioning(m, direction="foo") + compute_ill_conditioning_certificate(m, direction="foo") @pytest.fixture(scope="class") def model(self): @@ -3224,7 +3224,7 @@ def afiro(self): @pytest.mark.unit def test_beta(self, model, caplog): - check_ill_conditioning(model) + compute_ill_conditioning_certificate(model) expected = ( "Ill conditioning checks are a beta capability. Please be aware that " @@ -3236,7 +3236,7 @@ def test_beta(self, model, caplog): @pytest.mark.component @pytest.mark.solver def test_rows(self, model): - assert check_ill_conditioning(model, direction="row") == [ + assert compute_ill_conditioning_certificate(model, direction="row") == [ (model.c4, pytest.approx(0.50000002, rel=1e-5)), (model.c4, pytest.approx(0.49999998, rel=1e-5)), ] @@ -3244,7 +3244,7 @@ def test_rows(self, model): @pytest.mark.component @pytest.mark.solver def test_rows(self, afiro): - assert check_ill_conditioning(afiro, direction="row") == [ + assert compute_ill_conditioning_certificate(afiro, direction="row") == [ (afiro.R09, pytest.approx(0.5, rel=1e-5)), (afiro.R09b, pytest.approx(0.5, rel=1e-5)), ] @@ -3252,7 +3252,7 @@ def test_rows(self, afiro): @pytest.mark.component @pytest.mark.solver def test_columns(self, afiro): - assert check_ill_conditioning(afiro, direction="column") == [ + assert compute_ill_conditioning_certificate(afiro, direction="column") == [ (afiro.X39, pytest.approx(1.1955465, rel=1e-5)), (afiro.X23, pytest.approx(1.0668697, rel=1e-5)), (afiro.X25, pytest.approx(-1.0668697, rel=1e-5)),