diff --git a/idaes/core/util/model_diagnostics.py b/idaes/core/util/model_diagnostics.py index 20aefa14dc..cba946ee24 100644 --- a/idaes/core/util/model_diagnostics.py +++ b/idaes/core/util/model_diagnostics.py @@ -3142,9 +3142,6 @@ def check_parallel_jacobian(model, tolerance: float = 1e-4, direction: str = "ro Numerical Instability in Linear and Integer Programs, Informs 2014, pgs. 54-108 https://pubsonline.informs.org/doi/epdf/10.1287/educ.2014.0130 - We would also like to acknowledge Gurobi Model Analyzer for their implementation - of these methods (https://github.com/Gurobi/gurobi-modelanalyzer). - Args: model: model to be analysed tolerance: tolerance to use to determine if constraints/variables are parallel @@ -3234,9 +3231,6 @@ def check_ill_conditioning( Numerical Instability in Linear and Integer Programs, Informs 2014, pgs. 54-108 https://pubsonline.informs.org/doi/epdf/10.1287/educ.2014.0130 - We would also like to acknowledge Gurobi Model Analyzer for their implementation - of these methods (https://github.com/Gurobi/gurobi-modelanalyzer). - Args: model: model to be analysed target_feasibility_tol: target tolerance for solving ill conditioning problem diff --git a/idaes/core/util/tests/test_model_diagnostics.py b/idaes/core/util/tests/test_model_diagnostics.py index 2f6d421fb0..8022b15292 100644 --- a/idaes/core/util/tests/test_model_diagnostics.py +++ b/idaes/core/util/tests/test_model_diagnostics.py @@ -3076,12 +3076,17 @@ def test_rows(self, model): @pytest.mark.unit def test_columns(self, model): - assert check_parallel_jacobian(model, direction="column") == [ - (model.v1, model.v2), - (model.v1, model.v4), - (model.v2, model.v4), + pcol = check_parallel_jacobian(model, direction="column") + + expected = [ + ("v1", "v2"), + ("v1", "v4"), + ("v2", "v4"), ] + for i in pcol: + assert tuple(sorted([i[0].name, i[1].name])) in expected + class TestCheckIllConditioning: @pytest.mark.unit