Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PEtab.jl to work with version 3.x #1489

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Conversation

PaulJonasJost
Copy link
Collaborator

No description provided.

@PaulJonasJost PaulJonasJost self-assigned this Oct 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (8c35ccf) to head (74735e8).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
pypesto/objective/julia/petabJl.py 50.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1489      +/-   ##
===========================================
- Coverage    82.93%   82.90%   -0.04%     
===========================================
  Files          163      163              
  Lines        13790    13790              
===========================================
- Hits         11437    11432       -5     
- Misses        2353     2358       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebapersson
Copy link

Thanks for updating, everything looks good for me!

@PaulJonasJost PaulJonasJost marked this pull request as ready for review October 18, 2024 09:05
@PaulJonasJost
Copy link
Collaborator Author

removed the julia specific caching. We faced a lot of problems repeatedly due to that. Installing dependencies went from 9:45 (in gradient check example to 11:15. In my opinion the 2min extra (plus fluctuations obviously) are worth the less hassle (90% sure a lot of julia fails stemmed from the julia caching). What do you guys think @dweindl @Doresic @vwiela @dilpath?

@PaulJonasJost PaulJonasJost added this pull request to the merge queue Oct 23, 2024
Merged via the queue into develop with commit 47ae5d5 Oct 23, 2024
18 checks passed
@Doresic Doresic mentioned this pull request Oct 24, 2024
@PaulJonasJost PaulJonasJost mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants