ESSOptimizer: Fix recombination bug #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in the recombination step of the `ESSOptimizer`, also used by `SacessOptimizer`. This will in particular improve performance when using scatter search without local optimizers.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1477 +/- ##
===========================================
- Coverage 82.89% 82.88% -0.02%
===========================================
Files 163 163
Lines 13786 13786
===========================================
- Hits 11428 11426 -2
- Misses 2358 2360 +2 ☔ View full report in Codecov by Sentry. |
PaulJonasJost
approved these changes
Oct 2, 2024
| @@ -443,11 +443,15 @@ def _combine(self, i, j) -> np.array: | |||
| raise ValueError("i == j") | |||
| x = self.refset.x | |||
|
|
|||
| d = x[j] - x[i] | |||
| alpha = np.sign(j - i) | |||
| d = (x[j] - x[i]) / 2 | |||
There was a problem hiding this comment.
why was this changed to /2?
L446 + L450 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the recombination step of the
ESSOptimizer, also used bySacessOptimizer.This will in particular improve performance when using scatter search without local optimizers.