Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle numpy 2.0 with older packages #1433

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Handle numpy 2.0 with older packages #1433

merged 3 commits into from
Jul 30, 2024

Conversation

PaulJonasJost
Copy link
Collaborator

Remove <2.0 in hopes of all problems being resolved. fingers crossed

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.24%. Comparing base (71f7011) to head (5313489).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1433      +/-   ##
===========================================
- Coverage    83.25%   83.24%   -0.02%     
===========================================
  Files          161      161              
  Lines        13396    13396              
===========================================
- Hits         11153    11151       -2     
- Misses        2243     2245       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulJonasJost PaulJonasJost marked this pull request as ready for review July 29, 2024 14:02
Copy link
Contributor

@Doresic Doresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Doresic Doresic merged commit cda1cca into develop Jul 30, 2024
18 checks passed
@Doresic Doresic deleted the numpy_2.0_handling branch July 30, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants