Remove plaintext secret option #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get up to date with master
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kgcarr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kgcarr Please update the API as well |
chenzhiwei
reviewed
Mar 26, 2020
| } | ||
|
|
||
| user = createRandomAlphaNumeric(8) | ||
| pass = createRandomAlphaNumeric(13) |
There was a problem hiding this comment.
how to make this consist during the mongodb operator restart?
There was a problem hiding this comment.
@chenzhiwei the deployment supports changing the admin password on restarts, so it's ok for the admin secret to change
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part to address issue #67
We will not allow plaintext in the CR for username and password...so we will only allow random string admin and password
We will have to target adding a user supplied secret in Q2