Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a extendable GetEndpoint alternative taking model.Endpoints #345

Open
rlk833 opened this issue Oct 21, 2022 · 0 comments
Open

Have a extendable GetEndpoint alternative taking model.Endpoints #345

rlk833 opened this issue Oct 21, 2022 · 0 comments

Comments

@rlk833
Copy link

rlk833 commented Oct 21, 2022

My team has a plugin that needs to create endpoints url based on public/private/vpc and GetEndpoint could do it if I could pass in a models.Endpoints instead of an endpoints.Service.

This is because I need to duplicate all of the code that is done in GetEndpoint( with checking for vpc, private, public, staging, etc.

If I had an additional API GetEndpoint alternative call that takes a models.Endpoints I could just pass that in and let the common code do all of it. That way it would stay in sync if new function is added.

Now I have copy it and hopefully notice changes and keep it in sync in the processing logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant