Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Techno-economic #71

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

beijingzyl
Copy link

No description provided.

@danielhuppmann
Copy link
Member

Thank you @beijingzyl for opening this PR. This seems to be a straight copy from the NAVIGATE template, correct?

Can you please let me know whether you have had any discussions in the subgroup about possible improvements/extensions to the variables? For example, we aim to ensure easy readability of the variables and avoid abbreviations, so renaming "OM Cost" to "Operation and Maintenance Cost" might be worth considering. Also, there is a sub-category "Fixed" in the OM cost variables but there is specification of the "non-fixed" component...

@beijingzyl
Copy link
Author

@danielhuppmann Thank you for your feedback! This PR is from the AR6 template. We've made modifications, such as changing "capital cost" to "techno-economic" to better reflect its scope. We appreciate your suggestions on naming conventions and will consider them.

Regarding the "Fixed" in the OM cost variables, it indeed refers to fixed O&M costs. We noted there's no mention of a "non-fixed" counterpart, and it appears not to be a concept in AR6 either.

As for the validating error, it seems to be related to units after reviewing the error message, but I couldn't identify the exact issue. It's possible that the error arises from a mismatch between the expected and provided units, or there might have been incorrect unit conversions.

@danielhuppmann
Copy link
Member

Thank you, @beijingzyl.

The tests for your PR are currently failing because the yaml file is not in the right format - it should be a list (each item starting with -, not a yaml-dictionary).

A better starting point for your work can be found here, which is already in the right format. Also, please use all-lower-case names for files.

For units, please follow the new convention "USD_2010" instead of "US$2010" so that we can use the iam-units package for automated handling of unit validation and conversion. All other variables in this repo already follow this convention.

About the fixed O&M costs variables: the purpose of developing the common-definitions repository as a community activity is to review which variables make sense or should be revised. We set up a variable naming guidance here and the variables "OM Cost|Fixed|..." use an abbreviation and establish an un-used hierarchy level. Please discuss with the @IAMconsortium/common-definitions-techno-economic group on a better variable structure.

Copy link

@ouyang363 ouyang363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial commit, consistent with AR6

@danielhuppmann
Copy link
Member

Thank you @beijingzyl and @ouyang363 for implementing part of the requested changes.

However, you did not respond to my comment about improving the variable name for operation-and-maintenance costs:

About the fixed O&M costs variables: the purpose of developing the common-definitions repository as a community activity is to review which variables make sense or should be revised. We set up a variable naming guidance here and the variables "OM Cost|Fixed|..." use an abbreviation and establish an un-used hierarchy level. Please discuss with the @IAMconsortium/common-definitions-techno-economic group on a better variable structure.

@ouyang363
Copy link

thanks @danielhuppmann, this is just an initial implementation to make sure we can commit things (and @beijingzyl did it!) now we will make further improvement, discussing with the team!

@danielhuppmann
Copy link
Member

See beijingzyl#1 for a simplification and one specific question related to this PR.

Note that beijingzyl#1 is directed into the branch for this PR, so you first have to discuss and merge that other PR, then continue this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants