Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

504 Timeout should skip to next repo and not crash #27

Open
moshloop opened this issue Jun 11, 2019 · 2 comments
Open

504 Timeout should skip to next repo and not crash #27

moshloop opened this issue Jun 11, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers upstream-issue Related to an issue with Harbor Itself

Comments

@moshloop
Copy link

We have a few repo's that have grown quite large and return 504 timeouts when listing the tags, this crashes Tagd, it should rather log a warning, and continue to the next repo.

@nlowe nlowe added enhancement New feature or request good first issue Good for newcomers upstream-issue Related to an issue with Harbor Itself labels Jun 11, 2019
@nlowe
Copy link
Contributor

nlowe commented Jun 11, 2019

That makes sense to me. @moshloop Have you reported the issue to Harbor? We definitely shouldn't be timing out for larger repos.

@lf1029698952
Copy link

this is because harbor api perf issue, when list repo tags, will fetch tags all details, but the api fail in a deadlock, harbor api should refactoring And they're already doing it.
goharbor/harbor#6876
I hope before the problem is solved, tagd will skip timeout error and not crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers upstream-issue Related to an issue with Harbor Itself
Projects
None yet
Development

No branches or pull requests

3 participants