Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-1333: Remove helpers.js #6621

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Nov 8, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

The code on this file is use in activity log and users only and is affecting all the platform.

I left the method about CSRF, but I concealed the function. I think it will be safe to remove, but I don't want to introduce scope creep in this PR.

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 98fa9b2
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6732b033d46498000835e93f

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 98fa9b2
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6732b0332104bb0008bf0c3d

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.63%. Comparing base (d14d01e) to head (98fa9b2).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6621   +/-   ##
========================================
  Coverage    76.63%   76.63%           
========================================
  Files          169      169           
  Lines        13840    13840           
========================================
  Hits         10606    10606           
  Misses        3234     3234           
Flag Coverage Δ
pytests 76.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr luarmr merged commit e6e68f0 into develop Nov 12, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants