fix: Copy changes #5696
Closed
fix: Copy changes #5696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
hlomzik
reviewed
Apr 9, 2024
Comment on lines
-67
to
-76
| Predictions will be pre-loaded in {" "} | ||
| <a | ||
| style={{ color: "rgb(105 129 185)" }} | ||
| target="_blank" href="https://labelstud.io/guide/labeling.html#Choose-which-tasks-to-label" | ||
| >Label All Tasks</a>{" "} | ||
| and {" "} | ||
| <a | ||
| style={{ color: "rgb(105 129 185)" }} | ||
| target="_blank" href="https://labelstud.io/guide/get_started#Interface" | ||
| >Quick View</a>. |
There was a problem hiding this comment.
Looks like a helpful info given the diversity of affected workflows (and I believe some were missing here anyway, like action in DM to convert predictions into annotations?) + links to documentation.
Can we maybe rephrase this without removal? Why is it better to not have this info at all?
There was a problem hiding this comment.
The state of those linked docs is not great, and it would create more confusion that explain much. We first need to improve those sections, before we include it into the product. Overall, its simplicity.
hlomzik
reviewed
Apr 9, 2024
| </Description> | ||
| <Description style={{ marginTop: 0, display: "flex", gap: "5px" }} className="description_alert_warning"> | ||
| <IconInfo width="20" height="20" /> | ||
| If you want to use the model predictions for prelabeling, please configure this in the Annotation settings. |
There was a problem hiding this comment.
Link to Annotation settings would be helpful as we discussed
There was a problem hiding this comment.
Yes, I'm very supportive if you can implement that :)
hlomzik
reviewed
Apr 9, 2024
web/apps/labelstudio/src/components/Description/Description.styl
Outdated
Show resolved
Hide resolved
8 tasks
|
Closed in favor of #5712 |
hlomzik
added a commit
that referenced
this pull request
Apr 18, 2024
Annotation settings: - remove links to docs as they don't fully describe the flow Model settings: - also remove links - fix text describing how to use new model in labeling - add link to Annotation settings - simplify blocks used on a page <img width="456" alt="Screenshot 2024-04-10 at 23 58 00" src="https://github.com/HumanSignal/label-studio/assets/1607227/fc0084e2-0f26-459e-b282-6abf21a00b92"> <img width="688" alt="Screenshot 2024-04-10 at 23 57 48" src="https://github.com/HumanSignal/label-studio/assets/1607227/7a79402b-ebd9-40cb-837a-cc2c038a8b42"> Mirroring #5696 for Follow Merge ### PR fulfills these requirements - [ ] Tests for the changes have been added/updated (for bug fixes/features) - [ ] Docs have been added/updated (for bug fixes/features) - [x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.) - [x] Self-reviewed and ran all changes on a local instance (for bug fixes/features) #### Change has impacts in these area(s) - [ ] Product design - [ ] Backend (Database) - [ ] Backend (API) - [x] Frontend --------- Co-authored-by: Michael Malyuk <[email protected]> Co-authored-by: robot-ci-heartex <[email protected]> Co-authored-by: Michael Malyuk <[email protected]> Co-authored-by: hlomzik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This are the copy changes, removing doc links, and changing the language in a few places.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
(link to issue, supportive screenshots etc.)
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)