Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the meaning of neighborhood_limits #224

Open
cppcute-pm opened this issue Jul 19, 2023 · 4 comments
Open

the meaning of neighborhood_limits #224

cppcute-pm opened this issue Jul 19, 2023 · 4 comments

Comments

@cppcute-pm
Copy link

Hello, HuguesTHOMAS.
Thanks for your amazing work! In every calibration function of all the sampler classes, you remarked that:
Neighbors calibration: Set the "neighborhood_limits" (the maximum number of neighbors allowed in convolutions)
so that 90% of the neighborhoods remain untouched. There is a limit for each layer.
I'dont understand why some parts of the neighborhood points should remain untouched. And I want to use the KPConv module in my experiment and try to build a simpler dataloader, I'm wandering that whether it necessary to add a calibration function to gain the batch_limit and neighborhood_limits or I could just set the batch_num and neighborhood_num fixed with fixing number of downsampled points.

@HuguesTHOMAS
Copy link
Owner

You definitely can. The calibration function is here to simplify the parameter tuning by choosing an appropriate value depending on the point density. But you can set it yourself absolutely.

@cppcute-pm
Copy link
Author

Thanks for your reply! One more thing, could you explain why the calibration function needs the 90% of the neighborhoods remain untouched ? I don't understand.

@HuguesTHOMAS
Copy link
Owner

It does not "need" it. It is just a value you can decide for yourself. In my experiments, I noticed this was a good value as it already reduced the computations by a lot, while not losing any performance

@cppcute-pm
Copy link
Author

Thanks for your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants