Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumpversion: deprecate #183953

Merged
merged 1 commit into from
Sep 9, 2024
Merged

bumpversion: deprecate #183953

merged 1 commit into from
Sep 9, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 8, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Can look into adding the new successor bump-my-version as separate formula. Hopefully it survives better than prior versions.

@cho-m cho-m added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Sep 8, 2024
@github-actions github-actions bot added python Python use is a significant feature of the PR or issue formula deprecated Formula deprecated labels Sep 8, 2024
@stefanb
Copy link
Member

stefanb commented Sep 8, 2024

@cho-m
Copy link
Member Author

cho-m commented Sep 8, 2024

https://github.com/c4urself/bump2version?tab=readme-ov-file#bump2version mentions https://github.com/callowayproject/bump-my-version as a maintained successor

Yes. I did add a comment on that. Will look into a separate formula in different PR as it is now under a new name.

@cho-m cho-m mentioned this pull request Sep 8, 2024
6 tasks
@stefanb
Copy link
Member

stefanb commented Sep 8, 2024

Should this formula mention the successor formula somewhere, preferably visible to the end user, not just as a comment in ruby code?

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for deprecation message improvement in a separate PR.

@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 9, 2024
Merged via the queue into master with commit 4304999 Sep 9, 2024
17 checks passed
@BrewTestBot BrewTestBot deleted the bumpversion-deprecate branch September 9, 2024 09:56
@carlocab
Copy link
Member

carlocab commented Sep 9, 2024

I opened Homebrew/brew#18294 to track this more generally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants