Threshold

[Asd-g]

@msg7086, what do you think to change how the threshold is scaled? Left shift by 7 gives almost whole 16-bit range and keeps the current threshold limit [0,511].

[msg7086]

I don't quite get the context. What's the intention?

[Asd-g]

The intention is to expand the threshold effect. Currently there are 31 ranges and they can be 255.

[msg7086]

Make sense, sound good to me.

[Asd-g]

Currently there are 31 ranges and they can be 255.

I meant threshold ranges not the parameter ranges.

Take sample_mode=2, blur_first=true. Now threshold values between 1 and 16 return same output, threshold values between 17 and 32 return same output and so on... If the threshold is left shift by 5 instead of 2 - threshold values 1 and 2 return same output, threshold values 3 and 4 return same output and so on.

Take blur_first=false. Now threshold values between 1 and 64 return same output, threshold values between 65 and 128 return same output and so on. If the threshold is left shift by 5 instead of 2 - threshold values between 1 and 8 return same output, threshold between 9 and 16 return same output and so on.

The down side would be that the default threshold values have to be changed. Also the existing scripts using the filter have to be changed for the new thresholds.

[msg7086]

Also the existing scripts using the filter have to be changed for the new thresholds.

Better introducing new parameters as we don't want to break for everyone.

Try something like y2 cb2 cr2, default to -1, and do something like y2>=0?y2<<shift2:y<<shift.