Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend last-modified calculations for FRUS TEI to the tags collection #404

Open
joewiz opened this issue Apr 5, 2022 · 1 comment
Open
Labels

Comments

@joewiz
Copy link
Member

joewiz commented Apr 5, 2022

In #396 we implemented handling for Last-Modified and If-Modified-Since for TEI resources. For FRUS TEI, we derive the last modified date from the last modified dates of the TEI file itself and the associated bibliography file. However, volumes' landing pages are also constructed from the data in the https://github.com/HistoryAtState/tags repository. As a result, updates to a volume's tags such as HistoryAtState/tags@850d8b3 can be hidden from view, since eXist and Nginx think that the volume hasn't been updated. The last-modified calculation should extend to the data in the tags collection.

@joewiz joewiz added the bug label Apr 5, 2022
@joewiz
Copy link
Member Author

joewiz commented May 4, 2022

As reported by @joshbotts, this also affects updates of the POCOM data shown in SecState bios like https://history.state.gov/departmenthistory/people/albright-madeleine-korbel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant