Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ODD rules for lists #343

Open
plutonik-a opened this issue Aug 19, 2019 · 4 comments
Open

Fix ODD rules for lists #343

plutonik-a opened this issue Aug 19, 2019 · 4 comments
Assignees
@plutonik-a

Comments

@plutonik-a
Copy link
Contributor

plutonik-a commented Aug 19, 2019 •
edited
Loading

Possibly a regression bug caused by recent fixes for lists in frus.odd.

1. Nested Lists

image

2. False Font-weight Rendering in Lists

image

3. Lists in Element dateline

image
@plutonik-a plutonik-a changed the title Fix wrong ODD rules for lists returning elements in bold font-style Fix wrong ODD rules for lists returning elements in bold font-weight Aug 19, 2019
@plutonik-a plutonik-a changed the title Fix wrong ODD rules for lists returning elements in bold font-weight Fix wrong ODD rules for lists styling some elements in bold font-weight Aug 19, 2019
@plutonik-a plutonik-a changed the title Fix wrong ODD rules for lists styling some elements in bold font-weight Fix ODD rules for lists Aug 19, 2019
@plutonik-a plutonik-a self-assigned this Aug 19, 2019
plutonik-a added a commit that referenced this issue Aug 19, 2019
@plutonik-a
fix(#343): Apply css override rules for 'hi' elements
0ef5be0 
* override ignored output renditions and falsely set 'tei-hi1' classes
which contain font-weight strong rule
@plutonik-a
Copy link
Contributor Author

As I’ve found many variations of lists I wanted to check first with you, how (or if) a simple list without a bullet should be indented:
Should a simple list without any bullets or index numbers always have a left margin? Can it be left aligned like normal paragraphs and only following, nested sub lists will be indented?

1st. List example

https://history.state.gov/historicaldocuments/frus1917-72PubDipv07/sources

hsg-shell-list-01

The wrapping list element has no left indentation:
hsg-shell-list-02

The nested list will get margin-left, the first element is also a kind of list heading:
hsg-shell-list-03

2nd. List example

https://history.state.gov/historicaldocuments/frus1955-57v18/d18

hsg-shell-list-04

hsg-shell-list-05

hsg-shell-list-06

3rd. List example

https://history.state.gov/historicaldocuments/frus1955-57v18/terms

No left indentaion by default here
hsg-shell-list-07

joewiz added a commit that referenced this issue Aug 27, 2019
@joewiz
Merge pull request #346 from HistoryAtState/fix/frus-odd-#343
972d614 
Fix FRUS odd rules #343
plutonik-a added a commit that referenced this issue Oct 31, 2019
@plutonik-a
fix(#343): Apply css override rules for 'hi' elements
8b9e2c7 
* override ignored output renditions and falsely set 'tei-hi1' classes
which contain font-weight strong rule
@plutonik-a
Copy link
Contributor Author

@joewiz Regarding the markup of nested lists in general:
Could it be an option to simplify some of the lists and mark-up the content in a flatter structure?

I've found one example for this thought here
-> https://history.state.gov/historicaldocuments/frus1917-72PubDipv07/sources:

Screenshot 2019-11-08 at 11 47 56

This is a list containing only one element, so it could be easily removed and marked as a paragraph and the first <hi rend="strong"/> could be a <head> instead.

@joewiz
Copy link
Member

joewiz commented Nov 8, 2019

I can confirm that #346—now deployed to history.state.gov—fixes the font issues with italics and smallcaps evident in the initial post above.

@plutonik-a Thank you!

@joewiz
Copy link
Member

joewiz commented Dec 30, 2020

As reported by @KerryHite:

I was referring to the Person’s List for Reagan vol. III (Soviet Union) and saw that there is something funky going on with the Person’s list. It looks like there is a bullet for each entry superimposed on the second letter. It’s also like that for volume V. It is not like that in Carter Foundations.

See the bullet issue in https://history.state.gov/historicaldocuments/frus1981-88v03/persons, where the list of persons isn't flat but is grouped alphabetically into sublists:

Screen Shot 2020-12-30 at 10 00 52 AM

In contrast, when the list is flat, as in https://history.state.gov/historicaldocuments/frus1977-80v01/persons, there's no bullet issue.

A proper fix to this depends on #345, so I'm noting this here so we can check it when tackling that larger task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plutonik-a plutonik-a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joewiz @plutonik-a