Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jordan's old PR (#14) can't be reopened since it's set to merge into
master
and we deleted that branch when we switched to usingmain
.I'm checking all the boxes here to match where we left off, but there's still feedback in there that needs to be addressed. @ashabrah seemed like he may be interested in taking over the effort to get this ready for a vote. Is that accurate, Ashish?
Author checklist
Check boxes if requirement met or irrelevant.
First reviewer checklist
NOTE: Some of the author's checklist items are intentionally omitted, because they are a matter of opinion and up for discussion with the whole team.
Check boxes if requirement met or irrelevant.