-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4 channels IR files do not work anymore #3
Comments
Hi falkTX, thanks for reporting! I just tried to reproduce it on my computer, but here it worked perfectly fine. :-( In the changes you mentioned, I added additional support for FFTW. Which FFT do you use? The default is OouraFFT which shouldn't have changed. However, if the FFT were wrong, then I'd expect that the convolver doesn't work at all, but you described that the regular stereo case works as expected. Can you explain a little bit more detailed, what's not working anymore with 4-channel IR files. Does the plugin crash, or isn't there no reverb sound anymore or something like this? In the non-working 4-channel case, do you know whether already loading of the IRs fails? Are waveforms for all channels displayed in the UI? Which version of Juce do you use? I'm here still on a little dated version of Juce (2.0.32). Maybe I have to do some adaptions for the current version. Maybe I should update the KlangFalter to the latest Juce version (maybe this also helps with issue #2). Thank you so much for your efforts! :-) Regards, Uli |
Hi there. The issue with 4 channels seems to be that the wav files are not read correctly. |
Hi, I've updated KlangFalter now to the current head of Juce (which is at the moment 42aa27900b49ba75b5a2f15926256307c566c11a). I've also tried to include your changes regarding the settings directory on Linux, so I hope there shouldn't be much diff anymore between this and DISTHRO's version of KlangFalter. :-) Regarding the 4-channel IRs, anything new here? I also did some testing but everything seems to work fine (but on Mac, because I don't have a Linux system at hand at the moment). Greetings, Uli |
4 channels IR files used to work, but they don't anymore.
I believe either this 03fe806 or this d2c01c9 introduced the regression.
A test case are these free IR files:
http://www.samplicity.com/bricasti-m7-impulse-responses/
The generic wav files work fine, the quad ones do not.
The text was updated successfully, but these errors were encountered: