Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default lifetime & max views #220

Open
SecureCPU opened this issue Oct 6, 2023 · 11 comments
Open

Default lifetime & max views #220

SecureCPU opened this issue Oct 6, 2023 · 11 comments
Labels
Hacktoberfest help wanted Extra attention is needed

Comments

@SecureCPU
Copy link

Is there a way to set a default lifetime and default max views other than the original 4 hours?

@bjarneo
Copy link
Member

bjarneo commented Oct 6, 2023

No, not in the current state. It could easily be added though.

@ltguillaume
Copy link
Contributor

I'm really missing this, too.

4 hours is fine when talking to someone over IM, but for any other slow chat medium it will probably expire before the link is even clicked by the other party.

@SecureCPU
Copy link
Author

No, not in the current state. It could easily be added though.

Would be really awesome if it could be.
I use it to request credentials from clients and I usually have to ask the clients to make sure they change the expiration and max views. As we can't always get to their tickets withing the 4 hours or we check to make sure they sent the correct credentials and then come back to it at a later time.

@bjarneo
Copy link
Member

bjarneo commented Oct 16, 2023

I understand you need it. I just have limited time these days. The cool thing though is that this is open source, so feel free to add a PR solving this :)

Else I am not sure when it will be fixed.

@bjarneo bjarneo added help wanted Extra attention is needed Hacktoberfest labels Oct 16, 2023
@SecureCPU
Copy link
Author

I understand you need it. I just have limited time these days. The cool thing though is that this is open source, so feel free to add a PR solving this :)

Else I am not sure when it will be fixed.

Thanks.
Really appreciate and love your work! It's an awesome product!

@bjarneo
Copy link
Member

bjarneo commented Oct 16, 2023

Thank you for those kind words!

One thing that is a quick fix though, is to change the TTL to something higher as default without env config. What would be the ideal time? 24 hours? 72?

@SecureCPU
@ltguillaume

@SecureCPU
Copy link
Author

Thank you for those kind words!

One thing that is a quick fix though, is to change the TTL to something higher as default without env config. What would be the ideal time? 24 hours? 72?

@SecureCPU
@ltguillaume

I usually use 72. But not sure what others use.

@ltguillaume
Copy link
Contributor

Same here.

@bjarneo
Copy link
Member

bjarneo commented Oct 16, 2023

https://github.com/HemmeligOrg/Hemmelig.app/releases/tag/v5.13.2
0d175a6

I have not verified it works. Docker image are being built, will probably be released in 15 minutes.

@ltguillaume
Copy link
Contributor

Thanks @bjarneo!

@SecureCPU
Copy link
Author

Awesome!. Thank you so much!! I truly appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants