Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current version is broken on IITC Mobile #64

Closed
Augustronic opened this issue Feb 27, 2024 · 9 comments · Fixed by #65
Closed

Current version is broken on IITC Mobile #64

Augustronic opened this issue Feb 27, 2024 · 9 comments · Fixed by #65
Labels
bug Something isn't working

Comments

@Augustronic
Copy link

Hi!
Is the actual mobile version meant to run on Android?
It's not even showing up in my list of loaded plugins in "About IITC".
Cheers,
Augustronic

@ReVanTis
Copy link

I'm also having trouble running it on the latest IITC Mobile Beta, debug console shows:

<user-plugin/storage/emulated/0/IITC_Mobile/plugins/iitc_plugin_fanfields2.user.js>:683: Uncaught TypeError: window.pluginCreateHook is not a function

Seems a784022 introduces a regression on mobile.
I manually reverted it locally and it runs but without the book mark only feature.

@Augustronic
Copy link
Author

I'm also having trouble running it on the latest IITC Mobile Beta, debug console shows:

<user-plugin/storage/emulated/0/IITC_Mobile/plugins/iitc_plugin_fanfields2.user.js>:683: Uncaught TypeError: window.pluginCreateHook is not a function

Seems a784022 introduces a regression on mobile. I manually reverted it locally and it runs but without the book mark only feature.

You reverted the code changes or is there a versions repository?

@ReVanTis
Copy link

I'm also having trouble running it on the latest IITC Mobile Beta, debug console shows:

<user-plugin/storage/emulated/0/IITC_Mobile/plugins/iitc_plugin_fanfields2.user.js>:683: Uncaught TypeError: window.pluginCreateHook is not a function

Seems a784022 introduces a regression on mobile. I manually reverted it locally and it runs but without the book mark only feature.

You reverted the code changes or is there a versions repository?

I did it locally but you can try using this link for the version that before merging a784022:
Raw file link is here:
https://github.com/Heistergand/fanfields2/raw/19661ea3e5dff9659f7beecac9989ae68881dab9/iitc_plugin_fanfields2.user.js

from:
https://github.com/Heistergand/fanfields2/blob/19661ea3e5dff9659f7beecac9989ae68881dab9/iitc_plugin_fanfields2.user.js

@Augustronic
Copy link
Author

I'm also having trouble running it on the latest IITC Mobile Beta, debug console shows:

<user-plugin/storage/emulated/0/IITC_Mobile/plugins/iitc_plugin_fanfields2.user.js>:683: Uncaught TypeError: window.pluginCreateHook is not a function

Seems a784022 introduces a regression on mobile. I manually reverted it locally and it runs but without the book mark only feature.

You reverted the code changes or is there a versions repository?

I did it locally but you can try using this link for the version that before merging a784022: Raw file link is here: https://github.com/Heistergand/fanfields2/raw/19661ea3e5dff9659f7beecac9989ae68881dab9/iitc_plugin_fanfields2.user.js

from: https://github.com/Heistergand/fanfields2/blob/19661ea3e5dff9659f7beecac9989ae68881dab9/iitc_plugin_fanfields2.user.js

Excellent!
Thank you for the easy way!

@Heistergand Heistergand added the bug Something isn't working label Mar 6, 2024
@Heistergand
Copy link
Owner

I'll check on this.

@Heistergand Heistergand pinned this issue Mar 6, 2024
@Heistergand Heistergand changed the title Actual Android Mobile version? Current version is broken on IITC Mobile Mar 6, 2024
@Penumbruh
Copy link

Glad to see this is being worked on. I was able to get it to work on iOS and Chrome for Mac but I thought I was doing something wrong because I couldn't get it to come up on my Android phone.

@Heistergand
Copy link
Owner

Although I think I've fixed this and closed the issue, please update your IITC Plugins and test it. I welcome every feedback.

@Penumbruh
Copy link

Penumbruh commented Mar 6, 2024 via email

@Augustronic
Copy link
Author

It's working fine on my Samsung SS22 Android!
Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants