Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch.bmm kernel fusion #28

Open
Edenzzzz opened this issue Apr 17, 2024 · 0 comments
Open

torch.bmm kernel fusion #28

Edenzzzz opened this issue Apr 17, 2024 · 0 comments

Comments

@Edenzzzz
Copy link

Edenzzzz commented Apr 17, 2024

@DanFu09 Thanks for open-sourcing the code!
I see that in your previous fly repo(https://github.com/HazyResearch/fly), you used cast_inputs=torch.float16 for BlockdiagButterflyMultiply, but changed it to bf16 here. I wonder if there's a specific reason (e.g. fp16 training not converging due to range issues)?
Also, I wonder if there are opportunities for fusing the two bmm operations into one kernel? It seems hard to find the exact kernel torch is calling though.

@Edenzzzz Edenzzzz changed the title torch.bmm kernel fusion and precision casting issue in BlockdiagButterflyMultiply torch.bmm kernel fusion May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant