Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements #46

Closed
richteer opened this issue Sep 30, 2016 · 2 comments
Closed

Logging improvements #46

richteer opened this issue Sep 30, 2016 · 2 comments

Comments

@richteer
Copy link
Contributor

Right now, the log initialized in main.py always spews to stdout. There should be some way either by configuration or via the command line to specify a file for the log to write to instead (particularly useful if running interactively (python3 -i)).

Also, the log is stuck at a hardcoded level. It should also be configurable what level of detail should be outputted (DEBUG vs INFO, etc.)

Examples of the usage:

python3 main.py --logfile foo.log --loglevel DEBUG

...or in config.json:

{
    "logfile": "foo.log",
    "loglevel": "DEBUG",
...
}
@richteer
Copy link
Contributor Author

richteer commented Oct 25, 2016

This could follow a solution to #57, where config.json should be loaded in main.py before the logger is initialized.

@richteer
Copy link
Contributor Author

Implemented in PR #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant