Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring beaqle.js #14

Open
nise opened this issue Jan 30, 2019 · 3 comments
Open

refactoring beaqle.js #14

nise opened this issue Jan 30, 2019 · 3 comments

Comments

@nise
Copy link

nise commented Jan 30, 2019

The file beaqle.js has more then 1400 lines of code and contains about 53 functions. This is way too much. I would recommend to refactor the code to make it more clear and easy to extend. Currently there are many redundant functions.

At least each type of test should be stored in a separate file. From there you can call interfaces methods provided by the core of beaqle. The core should have multiple components such as the Audiopool, utils, and the listening test among others.

@seebk
Copy link
Member

seebk commented Jan 31, 2019

Yes, that would make sense as the file has grown bigger and bigger.

@timobaumann
Copy link
Contributor

pull request greatly appreciated.

@nise
Copy link
Author

nise commented Jan 31, 2019

I will see what I can do. So fare I've simplified a few functions and features that I did not need for my own experiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants