Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Refactor Microsoft login #3298

Open
3gf8jv4dv opened this issue Sep 25, 2024 · 2 comments
Open

[Feature] Refactor Microsoft login #3298

3gf8jv4dv opened this issue Sep 25, 2024 · 2 comments

Comments

@3gf8jv4dv
Copy link
Contributor

描述 | Description

You can have two login methods.

  • The first method is to click a button, open a specific link, and then directly log in to the corresponding account and give authorization;
  • The second method is to continue to use the form of manually entering the code (a QR code can be placed on the interface to facilitate authorization on mobile devices).

原因 | Reason

Inspired by the new implementation of Prism Launcher in its 9.0 development version. This refactoring will make the HMCL more modern and make the user login process more pleasant.

Preview

prismlauncher-microsoft-login-screen

@zkitefly
Copy link
Member

zkitefly commented Sep 28, 2024

Prism Launcher 是使用了两种不同的登录方式吗(Minecraft Launcher 的方法和登录设备流的方法(即网页输入代码连接))

如果是这样的话,制作两种登录方式感觉很麻烦,而且如果是要解决一些登录问题的话,那和 #3068 重复

只使用登录设备流方法来制作也可以,即 #3192 ,做到了不用手动输入代码即可连接,到时候可以改一下登录页面

如果是二维码打开 microsoft.com/link ,我感觉没必要,不过做一下也没事 🤔

@3gf8jv4dv
Copy link
Contributor Author

Prism Launcher 是使用了两种不同的登录方式吗(Minecraft Launcher 的方法和登录设备流的方法(即网页输入代码连接))

It looks like the Prism Launcher login method is still a little different than the Minecraft Launcher. The former, after accessing the link and selecting the target account and logging in, is similar to the device code flow, and also requires the user to give authorization, and then redirects to the login success page designed for them. The latter will call the system’s Xbox app for authorization. If you are interested you can download their GHA build and give it a try.

Here is their relevant PR:

只使用登录设备流方法来制作也可以,即 #3192 ,做到了不用手动输入代码即可连接,到时候可以改一下登录页面

Is not it #3203?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants