Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra memory for adjointfield #41

Open
simone-romiti opened this issue Feb 21, 2023 · 0 comments
Open

Extra memory for adjointfield #41

simone-romiti opened this issue Feb 21, 2023 · 0 comments

Comments

@simone-romiti
Copy link
Collaborator

The values of the adjoint field are stored in the data attribute. In the constructor, this is resized to volume*4 https://github.com/urbach/su2/blob/7d4a9bfd9b7d6ef20e3f91e5bcbca2f42d038d11/include/adjointfield.hh#L107

but it should be volume*ndims. This didn't cause issues on previous runs because all loops have limits deduced by other methods of the class, so the extra entries of the array are simply unused when ndims < 4

@simone-romiti simone-romiti changed the title Extra storage space for adjointfield Extra memory for adjointfield Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant