Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateCaloCells vs CreateCaloCellsNoise #99

Open
giovannimarchiori opened this issue Jul 22, 2024 · 0 comments
Open

CreateCaloCells vs CreateCaloCellsNoise #99

giovannimarchiori opened this issue Jul 22, 2024 · 0 comments

Comments

@giovannimarchiori
Copy link
Contributor

giovannimarchiori commented Jul 22, 2024

do we need both
https://github.com/HEP-FCC/k4RecCalorimeter/blob/main/RecCalorimeter/src/components/CreateCaloCells.h
and
https://github.com/HEP-FCC/k4RecCalorimeter/blob/main/RecCalorimeter/src/components/CreateCaloCellsNoise.h
?

They seem to be essentially identical bar
(1) the latter misses cross-talk, added recently by Zhibo
(2) CreateCaloCellsNoise operates on a DataHandleedm4hep::CalorimeterHitCollection
while CreateCaloCells operates on a DataHandleedm4hep::SimCalorimeterHitCollection

If the latter is really needed, then should we add x-talk to it?
Otherwise, can this be put in the dustbin?

Tagging @BrieucF , @faltovaj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant