You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
They seem to be essentially identical bar
(1) the latter misses cross-talk, added recently by Zhibo
(2) CreateCaloCellsNoise operates on a DataHandleedm4hep::CalorimeterHitCollection
while CreateCaloCells operates on a DataHandleedm4hep::SimCalorimeterHitCollection
If the latter is really needed, then should we add x-talk to it?
Otherwise, can this be put in the dustbin?
do we need both
https://github.com/HEP-FCC/k4RecCalorimeter/blob/main/RecCalorimeter/src/components/CreateCaloCells.h
and
https://github.com/HEP-FCC/k4RecCalorimeter/blob/main/RecCalorimeter/src/components/CreateCaloCellsNoise.h
?
They seem to be essentially identical bar
(1) the latter misses cross-talk, added recently by Zhibo
(2) CreateCaloCellsNoise operates on a DataHandleedm4hep::CalorimeterHitCollection
while CreateCaloCells operates on a DataHandleedm4hep::SimCalorimeterHitCollection
If the latter is really needed, then should we add x-talk to it?
Otherwise, can this be put in the dustbin?
Tagging @BrieucF , @faltovaj
The text was updated successfully, but these errors were encountered: