Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comment about multi VFD duplication #5029

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Remove comment about multi VFD duplication #5029

merged 1 commit into from
Oct 29, 2024

Conversation

derobins
Copy link
Member

@derobins derobins commented Oct 29, 2024 •
edited
Loading

We used to duplicate the warning macros in H5FDmulti.c when they were in
H5private.h. Now that they are in a separate header, we can use them
directly.

@derobins derobins added Priority - 2. Medium ⏹ It would be nice to have this in the next release Component - C Library Core C library issues (usually in the src directory) Type - Improvement Improvements that don't add a new feature or functionality labels Oct 29, 2024
qkoziol
qkoziol reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@qkoziol qkoziol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we are installing this header, we shouldn't use any non-public header files in the multi (or stdio) VFDs. They should not depend on anything internal to the library.

@derobins
Copy link
Member Author

Unless we are installing this header, we shouldn't use any non-public header files in the multi (or stdio) VFDs. They should not depend on anything internal to the library.

They are just the warning suppression macros. There's no reason for them to be considered private. I wouldn't make them public, but anyone could use that file.

@derobins derobins merged commit 1e977c1 into HDFGroup:develop Oct 29, 2024
65 checks passed
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Oct 31, 2024
@derobins @brtnfld
Remove comment about multi VFD duplication (HDFGroup#5029)
68d2b79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkoziol qkoziol qkoziol left review comments

@byrnHDF byrnHDF byrnHDF approved these changes

@hyoklee hyoklee hyoklee approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues (usually in the src directory) Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derobins @hyoklee @qkoziol @byrnHDF